• Skull giver@popplesburger.hilciferous.nl
    link
    fedilink
    English
    arrow-up
    30
    ·
    1 year ago

    For large scale patches: definitely. It’s often easier for a project to let its own experts write their own 100 line patch than it is to review someone else’s 100 line patch.

    In this instance: it’s a changelog entry and a patch to a C file (8 insertions(+), 1 deletion(-)). Remove the printed warning and you’re back to 5 insertions. Furthermore, the patch has already been merged upstream.

    Redhat is free to choose what patches they do and do not accept and the low quality Reddit outrage posts in the Gitlab issue sure doesn’t make things any better, but this is quite a silly thing to refuse to merge.